Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 90.69% 90.69%
=======================================
Files 143 143
Lines 2471 2471
=======================================
Hits 2241 2241
Misses 230 230 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR improves code documentation standards by removing docstring rule exceptions and adding documentation where previously ignored. The changes enable stricter enforcement of docstring requirements for public packages and __init__ methods.
Key Changes:
- Enabled stricter docstring checks by removing D104 and D107 exceptions
- Added compliant
__init__docstring to MockItem test class
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/multisafepay/unit/api/base/listings/test_unit_listing.py | Added docstring to MockItem.init method to comply with newly enabled D107 rule |
| pyproject.toml | Removed D104 and D107 from ignore list to enforce docstring requirements for public packages and init methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danielcivit
approved these changes
Dec 3, 2025
danielcivit
pushed a commit
that referenced
this pull request
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes minor improvements to code documentation and configuration. The most important changes are:
Documentation improvements:
__init__method of theMockItemclass intests/multisafepay/unit/api/base/listings/test_unit_listing.pyto clarify its purpose.Configuration updates:
D104andD107from theignorelist in theextend-safe-fixessection ofpyproject.toml, potentially enabling stricter docstring checks for missing docstrings in public packages and methods.